feat: incorporate schema for postgresql and add integration test #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
RogerHYang
commented
Sep 3, 2024
integration_tests/conftest.py
Outdated
There was a problem hiding this comment.
copied from #4470
RogerHYang
commented
Sep 3, 2024
| # Applying this workaround: https://github.com/actions/runner/issues/822 | ||
| image: ${{ (matrix.os == 'ubuntu-latest') && 'postgres:12' || '' }} | ||
| env: | ||
| POSTGRES_PASSWORD: phoenix |
There was a problem hiding this comment.
setting a distinct password to avoid making inadvertent connections when running locally
mikeldking
reviewed
Sep 3, 2024
Comment on lines
+134
to
+140
| def set_postgresql_search_path(schema: str) -> Callable[[Connection, Any], None]: | ||
| def _(connection: Connection, _: Any) -> None: | ||
| cursor = connection.cursor() | ||
| cursor.execute(f"CREATE SCHEMA IF NOT EXISTS {schema};") | ||
| cursor.execute(f"SET search_path TO {schema};") | ||
|
|
||
| return _ |
There was a problem hiding this comment.
what happens if the schema is set after you've already bootstrapped the DB?
There was a problem hiding this comment.
it'll be created as a new one: that's how the integration tests work
mikeldking
reviewed
Sep 3, 2024
mikeldking
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4212
resolves #4302