-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: incorporate schema for postgresql and add integration test #4474
Conversation
integration_tests/conftest.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from #4470
# Applying this workaround: https://github.com/actions/runner/issues/822 | ||
image: ${{ (matrix.os == 'ubuntu-latest') && 'postgres:12' || '' }} | ||
env: | ||
POSTGRES_PASSWORD: phoenix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting a distinct password to avoid making inadvertent connections when running locally
def set_postgresql_search_path(schema: str) -> Callable[[Connection, Any], None]: | ||
def _(connection: Connection, _: Any) -> None: | ||
cursor = connection.cursor() | ||
cursor.execute(f"CREATE SCHEMA IF NOT EXISTS {schema};") | ||
cursor.execute(f"SET search_path TO {schema};") | ||
|
||
return _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if the schema is set after you've already bootstrapped the DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'll be created as a new one: that's how the integration tests work
resolves #4212
resolves #4302