Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): soft-delete users #4562

Merged
merged 6 commits into from
Sep 10, 2024
Merged

fix(auth): soft-delete users #4562

merged 6 commits into from
Sep 10, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Sep 10, 2024

Instead of deleting actual tuples in the users table, just soft-delete users by adding the deleted_at timestamp. Update other routes and resolvers accordingly.

resolves #4561

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 10, 2024
@axiomofjoy axiomofjoy changed the base branch from main to auth September 10, 2024 17:40
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Sep 10, 2024
Copy link
Contributor

@anticorrelator anticorrelator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this PR supposed to implement the actual delete operation or just handle soft-deleted users

@anticorrelator
Copy link
Contributor

Maybe add more detail to the PR message if the intent was to handle soft-deleted uses better in our gql routes?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@axiomofjoy axiomofjoy merged commit 98cd236 into auth Sep 10, 2024
15 checks passed
@axiomofjoy axiomofjoy deleted the xander/soft-delete-users branch September 10, 2024 21:30
RogerHYang pushed a commit that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auth][graphql] soft-delete users
2 participants