feat: smtp for password reset #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
mikeldking
reviewed
Sep 17, 2024
| body: JSON.stringify(params), | ||
| }); | ||
| if (!response.ok) { | ||
| setError("Failed attempt"); |
There was a problem hiding this comment.
Error is not clear - make the message more clear to the user what might be wrong
| setError("Failed attempt"); | ||
| return; | ||
| } | ||
| } catch (error) { |
There was a problem hiding this comment.
Not sure you need this try catch here
axiomofjoy
reviewed
Sep 17, 2024
axiomofjoy
reviewed
Sep 17, 2024
axiomofjoy
reviewed
Sep 17, 2024
RogerHYang
commented
Sep 17, 2024
axiomofjoy
reviewed
Sep 17, 2024
mikeldking
approved these changes
Sep 18, 2024
| body: JSON.stringify(params), | ||
| }); | ||
| if (!response.ok) { | ||
| setError("Failed attempt"); |
There was a problem hiding this comment.
Needs a better error message
| return; | ||
| } | ||
| } catch (error) { | ||
| setError("Failed attempt"); |
There was a problem hiding this comment.
needs a better error message
Comment on lines
+38
to
+40
| setMessage( | ||
| "A link to reset your password has been sent. Check your email for details." | ||
| ); |
There was a problem hiding this comment.
I can do the follow-up but this typically swaps out the UI
Comment on lines
+14
to
+18
| const token = searchParams.get("token"); | ||
| if (!token) { | ||
| navigate("/login"); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I would probably just show an error. We need a "back to login" link anyways. Redirecting typically should happen on user-action - it might be confusing otherwise.
dosubot
bot
added
size:XXL
RogerHYang
commented
Sep 18, 2024
axiomofjoy
reviewed
Sep 18, 2024
axiomofjoy
reviewed
Sep 18, 2024
axiomofjoy
approved these changes
Sep 18, 2024
RogerHYang
added a commit
that referenced
this pull request
Sep 21, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4602
resolves #4054
resolves #4055