Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch from db on token cache miss #4723

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/phoenix/server/jwt_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,15 @@ def _encode(self, claim: ClaimSet) -> str:
return jwt.encode(payload, self._secret, algorithm=self._algorithm)

async def get(self, token_id: _TokenIdT) -> Optional[_ClaimSetT]:
return self._claims.get(token_id)
if claims := self._claims.get(token_id):
return claims
async with self._db() as session:
record = await session.scalar(self._update_stmt.where(self._table.id == int(token_id)))
if not record:
return None
_, claims = self._from_db(record, record.User.role)
self._claims[token_id] = claims
return claims

async def evict(self, token_id: _TokenIdT) -> Optional[_ClaimSetT]:
return self._claims.pop(token_id, None)
Expand Down
Loading