Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): show reset password button only for locally authenticated users #4842

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Oct 2, 2024

Show option to reset password only for locally authenticated users. We're currently showing it to users authenticated via a third-party OAuth2 IDP, which doesn't make sense.

Locally Authenticated User

Screenshot 2024-10-02 at 3 23 55 PM

OAuth2 Authenticated User

Screenshot 2024-10-02 at 3 24 13 PM

resolves #4727

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 2, 2024
@axiomofjoy axiomofjoy merged commit 1016fff into main Oct 2, 2024
9 checks passed
@axiomofjoy axiomofjoy deleted the xander/no-password-reset-for-oauth-users branch October 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auth][ui][bug] don't show reset password button in oauth2 user profiles
2 participants