feat: Scaffold ts phoenix client using openapi-typescript #4928
Conversation
dosubot
bot
added
the
size:XXL
| @@ -14,23 +14,24 @@ | |||
| "scripts": { | |||
| "clean": "rimraf dist", | |||
| "prebuild": "pnpm run clean && pnpm run generate", | |||
| "generate": "openapi-ts", | |||
| "generate": "openapi-typescript ../../../schemas/openapi.json -o ./src/lib/api/v1.d.ts", | |||
There was a problem hiding this comment.
| "generate": "openapi-typescript ../../../schemas/openapi.json -o ./src/lib/api/v1.d.ts", | |
| "generate": "openapi-typescript ../../../schemas/openapi.json -o ./src/schema.d.ts", |
@cephalization why not just put it at the root of src?
There was a problem hiding this comment.
alternatively could use relay syntax __generated__
There was a problem hiding this comment.
Leaving root open lets us build out wrapping structures or extra utils on top of the generated code without co-mingling it. I can rename to generated though
| }; | ||
|
|
||
| export const createClient = ( | ||
| options: ClientOptions = { baseUrl: "http://localhost:6006" }, |
There was a problem hiding this comment.
we should support the same environment variables here
There was a problem hiding this comment.
Good call, although I am a bit wary because it makes the code less isomorphic. I can do some feature detection on process.env probably so that this code still runs in all runtimes
| }; | ||
| "/v1/datasets/{id}": { | ||
| parameters: { | ||
| query?: never; |
There was a problem hiding this comment.
@cephalization this is weird - is it something we can configure? it should be at least any here
There was a problem hiding this comment.
Something is definitely messed up. The last openapi codegen tool I used strongly typed the query parameters of each endpoint and I'd expect the same here
There was a problem hiding this comment.
Looks like later on in the generated types it overrides these never types with the appropriate types
No description provided.