Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch to Vitest from Jest #4955

Merged
merged 2 commits into from
Oct 11, 2024
Merged

refactor: Switch to Vitest from Jest #4955

merged 2 commits into from
Oct 11, 2024

Conversation

cephalization
Copy link
Contributor

Benefits:

  • Speed
  • Single build pipeline instead of two
    • Now app build and test runs both use the same vite config instead of one vite build and one esbuild build
    • Build plugins now work for builds and tests, no longer need to duplicate
  • Interesting future features
    • "Browser Mode" testing that can run your unit tests in playwright instead of node + jsdom, meaning unit tests will catch browser runtime issues that won't be caught in node

@cephalization
Copy link
Contributor Author

More selfishly, this enables tests to be written for #4943, which currently adds a rollup plugin incompatible with jest/esbuild

@cephalization cephalization marked this pull request as ready for review October 11, 2024 16:39
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 11, 2024
@cephalization cephalization merged commit 85415e4 into main Oct 11, 2024
7 checks passed
@cephalization cephalization deleted the vitest branch October 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants