Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add db table for trace sessions #4961

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: add db table for trace sessions #4961

merged 1 commit into from
Oct 18, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Oct 11, 2024 •
edited
Loading

resolves #4854
resolves #5010

Notes

  • Added project_sessions with foreign key on traces
  • Since each span can have a different the project name, to eliminate ambiguity, the project for the session is defined by the span with the max end_time.
Screenshot 2024-10-15 at 3 59 01 PM

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 11, 2024
@RogerHYang RogerHYang marked this pull request as draft October 11, 2024 16:27
@RogerHYang RogerHYang changed the base branch from main to playground October 11, 2024 20:43
@RogerHYang RogerHYang force-pushed the db-changes-for-session branch 9 times, most recently from 7113eb7 to 89a7fb6 Compare October 14, 2024 22:17
@RogerHYang RogerHYang marked this pull request as ready for review October 14, 2024 22:17
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
mikeldking
mikeldking reviewed Oct 15, 2024
View reviewed changes
app/schema.graphql Outdated Show resolved Hide resolved
mikeldking
mikeldking approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/schema.graphql Outdated Show resolved Hide resolved
src/phoenix/db/insertion/span.py Outdated Show resolved Hide resolved
src/phoenix/db/insertion/span.py Outdated Show resolved Hide resolved
axiomofjoy
axiomofjoy approved these changes Oct 15, 2024
View reviewed changes
src/phoenix/server/api/types/Project.py Outdated Show resolved Hide resolved
src/phoenix/db/models.py Show resolved Hide resolved
@RogerHYang RogerHYang linked an issue Oct 16, 2024 that may be closed by this pull request
[sessions][gql] project sessions connection #5010
Closed
@RogerHYang RogerHYang changed the base branch from playground to main October 16, 2024 18:36
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@RogerHYang RogerHYang changed the base branch from main to playground October 16, 2024 18:37
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 16, 2024
@dosubot dosubot bot removed the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 16, 2024
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 16, 2024
@RogerHYang RogerHYang changed the base branch from playground to main October 17, 2024 21:09
@RogerHYang RogerHYang changed the base branch from main to sessions October 17, 2024 21:09
@RogerHYang RogerHYang merged commit 4e495b1 into sessions Oct 18, 2024
41 of 43 checks passed
@RogerHYang RogerHYang deleted the db-changes-for-session branch October 18, 2024 17:59
RogerHYang added a commit that referenced this pull request Oct 22, 2024
@RogerHYang
feat: add db table for sessions (#4961)
83125e2
RogerHYang added a commit that referenced this pull request Oct 23, 2024
@RogerHYang
feat: add db table for sessions (#4961)
a3baf2c
RogerHYang added a commit that referenced this pull request Oct 23, 2024
@RogerHYang
feat: add db table for sessions (#4961)
2ccf252
RogerHYang added a commit that referenced this pull request Oct 25, 2024
@RogerHYang
feat: add db table for sessions (#4961)
aee3252
RogerHYang added a commit that referenced this pull request Oct 25, 2024
@RogerHYang
feat: add db table for sessions (#4961)
0bbd3f5
RogerHYang added a commit that referenced this pull request Oct 28, 2024
@RogerHYang
feat: add db table for sessions (#4961)
fa61dd6
RogerHYang added a commit that referenced this pull request Oct 29, 2024
@RogerHYang
feat(sessions): add db table for sessions (#4961)
ba9391f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sessions][gql] project sessions connection [sessions] DB ERD
3 participants
@RogerHYang @mikeldking @axiomofjoy