feat(playground): parse model name and infer provider form span #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
…fined deployment names
Parker-Stafford
commented
Oct 15, 2024
| /> | ||
| {instance.model.provider === "AZURE_OPENAI" ? ( | ||
| <TextField | ||
| label="Deployment Name" |
There was a problem hiding this comment.
can have this as model, not sure what's easier for users, technically we need the deployment name
Parker-Stafford
commented
Oct 15, 2024
mikeldking
reviewed
Oct 16, 2024
Comment on lines
141
to
143
| if (modelName.includes("gpt") || modelName.includes("o1")) { | ||
| return "OPENAI"; | ||
| } |
There was a problem hiding this comment.
should we just have prefix maps? e.g. OPENAI_MODEL_PREFIXES = ['gpt', 'o1']
There was a problem hiding this comment.
yup can do that
mikeldking
reviewed
Oct 16, 2024
Comment on lines
+161
to
+162
| | { modelConfig: ModelConfig; parsingErrors: never[] } | ||
| | { modelConfig: null; parsingErrors: string[] } { |
mikeldking
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4998
Screen.Recording.2024-10-15.at.3.26.56.PM.mov
Small fix on azure
Azure OpenAI api requires you to pass in a string model name which matches the deployment name which is user defined (backed by a real open ai model)
Note: Still missing - azure endpoint / api version: #5023
Screen.Recording.2024-10-15.at.3.38.47.PM.mov