-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): parse model name and infer provider form span #5021
feat(playground): parse model name and infer provider form span #5021
Conversation
…fined deployment names
/> | ||
{instance.model.provider === "AZURE_OPENAI" ? ( | ||
<TextField | ||
label="Deployment Name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can have this as model, not sure what's easier for users, technically we need the deployment name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
if (modelName.includes("gpt") || modelName.includes("o1")) { | ||
return "OPENAI"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just have prefix maps? e.g. OPENAI_MODEL_PREFIXES = ['gpt', 'o1']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup can do that
| { modelConfig: ModelConfig; parsingErrors: never[] } | ||
| { modelConfig: null; parsingErrors: string[] } { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woa getting fancy now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe be get some Azure fixtures setup to test
resolves #4998
Screen.Recording.2024-10-15.at.3.26.56.PM.mov
Small fix on azure
Azure OpenAI api requires you to pass in a string model name which matches the deployment name which is user defined (backed by a real open ai model)
Note: Still missing - azure endpoint / api version: #5023
Screen.Recording.2024-10-15.at.3.38.47.PM.mov