Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make model listing more generic #5022

Merged
merged 7 commits into from
Oct 16, 2024
Merged

feat: make model listing more generic #5022

merged 7 commits into from
Oct 16, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Oct 15, 2024

makes the model listing more generic so that you can view a full list of available models.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 15, 2024
@mikeldking mikeldking marked this pull request as draft October 15, 2024 22:37
@cephalization
Copy link
Contributor

image

@mikeldking mikeldking marked this pull request as ready for review October 15, 2024 23:47
Comment on lines +179 to +180
if input is not None and input.provider_key is not None:
return [model for model in all_models if model.provider_key == input.provider_key]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

src/phoenix/server/api/queries.py Outdated Show resolved Hide resolved
mikeldking and others added 2 commits October 16, 2024 09:55
Co-authored-by: Xander Song <axiomofjoy@gmail.com>
@mikeldking mikeldking changed the base branch from playground to main October 16, 2024 19:57
@mikeldking mikeldking merged commit fd0c6ce into main Oct 16, 2024
30 of 31 checks passed
@mikeldking mikeldking deleted the model-listing branch October 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants