feat(playground): wire up tool calling ui #5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
dosubot
bot
added
size:L
| @@ -81,6 +81,7 @@ export function PlaygroundTool({ | |||
| instanceId: playgroundInstanceId, | |||
| patch: { | |||
| tools: instanceTools.filter((t) => t.id !== tool.id), | |||
| toolChoice: undefined, | |||
There was a problem hiding this comment.
why do we need this? i mean moving to undefined, does openai not want something if there are no tools?
There was a problem hiding this comment.
exactly, the openai api throws if you send in tool_choice but no tools.
Parker-Stafford
approved these changes
Oct 16, 2024
axiomofjoy
force-pushed
the
xander/playground-tool-call-frontend
branch
from
e3df4fd
to
ff7c53d
Compare
|
Looks like these playwright tests are failing on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires up tool calling in the UI.
tool_calling_demo.mp4
resolves #4988