Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): wire up tool calling ui #5029

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Oct 16, 2024

Wires up tool calling in the UI.

tool_calling_demo.mp4

resolves #4988

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 16, 2024
@axiomofjoy axiomofjoy marked this pull request as draft October 16, 2024 05:46
@axiomofjoy axiomofjoy changed the base branch from main to xander/playground-tool-calls October 16, 2024 05:46
@axiomofjoy axiomofjoy marked this pull request as ready for review October 16, 2024 07:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 16, 2024
@@ -81,6 +81,7 @@ export function PlaygroundTool({
instanceId: playgroundInstanceId,
patch: {
tools: instanceTools.filter((t) => t.id !== tool.id),
toolChoice: undefined,
Copy link
Contributor

@Parker-Stafford Parker-Stafford Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? i mean moving to undefined, does openai not want something if there are no tools?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, the openai api throws if you send in tool_choice but no tools.

Base automatically changed from xander/playground-tool-calls to playground October 16, 2024 18:03
@axiomofjoy axiomofjoy force-pushed the xander/playground-tool-call-frontend branch from e3df4fd to ff7c53d Compare October 16, 2024 18:18
@axiomofjoy
Copy link
Contributor Author

Looks like these playwright tests are failing on the playground branch as well. Merging.

@axiomofjoy axiomofjoy merged commit 75b7000 into playground Oct 16, 2024
29 of 30 checks passed
@axiomofjoy axiomofjoy deleted the xander/playground-tool-call-frontend branch October 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[playground][gql] model tool calling parameters
2 participants