Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: git ignore symbolic links #5046

Merged
merged 3 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 2 additions & 36 deletions .github/workflows/python-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ jobs:

ruff:
name: Ruff
needs: changes
if: ${{ needs.changes.outputs.phoenix == 'true' }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
Expand Down Expand Up @@ -163,15 +165,6 @@ jobs:
sparse-checkout: |
requirements/
src/phoenix/
- name: Remove symbolic links (Non-Windows)
run: find . -type l -delete
if: runner.os != 'Windows'
- name: Remove symbolic links (Windows)
run: |
Remove-Item src/phoenix/evals
Remove-Item src/phoenix/otel
shell: powershell
if: runner.os == 'Windows'
- name: Set up Python ${{ matrix.py }}
uses: actions/setup-python@v5
with:
Expand Down Expand Up @@ -209,15 +202,6 @@ jobs:
src/phoenix/
tests/unit/
tests/conftest.py
- name: Remove symbolic links (non-Windows)
run: find . -type l -delete
if: runner.os != 'Windows'
- name: Remove symbolic links (Windows)
run: |
Remove-Item src/phoenix/evals
Remove-Item src/phoenix/otel
shell: powershell
if: runner.os == 'Windows'
- name: Set up Python ${{ matrix.py }}
uses: actions/setup-python@v5
with:
Expand Down Expand Up @@ -261,15 +245,6 @@ jobs:
requirements/
src/phoenix/
tests/integration/
- name: Remove symbolic links (Non-Windows)
run: find . -type l -delete
if: runner.os != 'Windows'
- name: Remove symbolic links (Windows)
run: |
Remove-Item src/phoenix/evals
Remove-Item src/phoenix/otel
shell: powershell
if: runner.os == 'Windows'
- name: Set up Python ${{ matrix.py }}
uses: actions/setup-python@v5
with:
Expand Down Expand Up @@ -328,15 +303,6 @@ jobs:
requirements/
src/phoenix/
tests/integration/
- name: Remove symbolic links (non-Windows)
run: find . -type l -delete
if: runner.os != 'Windows'
- name: Remove symbolic links (Windows)
run: |
Remove-Item src/phoenix/evals
Remove-Item src/phoenix/otel
shell: powershell
if: runner.os == 'Windows'
- name: Set up Python ${{ matrix.py }}
uses: actions/setup-python@v5
with:
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,7 @@ examples/agent_framework_comparison/utils/saved_traces/*.parquet
# python environments
.conda
.venv

# Symbolic links
src/phoenix/evals
src/phoenix/otel
1 change: 0 additions & 1 deletion src/phoenix/evals

This file was deleted.

1 change: 0 additions & 1 deletion src/phoenix/otel

This file was deleted.

16 changes: 16 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,19 @@ commands_pre =
uv pip install --reinstall .
commands =
mypy {posargs:.}

[testenv:add_symlinks]
changedir = {toxinidir}/src/phoenix
allowlist_externals =
ln
commands =
ln -sf ../../packages/phoenix-evals/src/phoenix/evals evals
ln -sf ../../packages/phoenix-otel/src/phoenix/otel otel

[testenv:remove_symlinks]
RogerHYang marked this conversation as resolved.
Show resolved Hide resolved
changedir = {toxinidir}/src/phoenix
allowlist_externals =
unlink
commands =
unlink evals
unlink otel
Loading