Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): return finalized span at end of subscription #5089

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Oct 17, 2024

returns span on last subscription payload

subscription ChatCompletionSubscription($input: ChatCompletionInput!) {
  chatCompletion(input: $input) {
    ... on TextChunk {
      content
    }
    ... on ToolCallChunk {
      id
      function {
        name
        arguments
      }
    }
    ... on FinishedChatCompletion {
      span {
        id
      }
    }
  }
}

resolves #5037
resolves #5091
resolves #5037

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 17, 2024
@axiomofjoy axiomofjoy merged commit 6ca4288 into main Oct 18, 2024
33 checks passed
@axiomofjoy axiomofjoy deleted the xander/return-span branch October 18, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
2 participants