fix(playground): improve playground error handling #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
| exception_stacktrace=format_exc(), | ||
| ) | ||
| ) | ||
| yield ChatCompletionSubscriptionError(message=status_message) |
There was a problem hiding this comment.
don't know if this matters as much on non SaaS, we could put a prefix on the error if it came from the llm provider, just to inform the user that the error did not happen in our system but happened in a third party api e.g., OpenAI API Error: status_message. Have to parse out where the error comes from which can be a pain though
There was a problem hiding this comment.
I think this is a good idea. We don't currently have a display name in the backend for the providers, just a provider key (e.g., openai without the nice casing). Let's punt until we have.
Parker-Stafford
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error_handling.mp4
Improves error handling to yield an error type in the subscription so we can still return the final span at the end, even if an error occurs midway.
resolves #5187