feat(sessions): sessions table on project page #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
RogerHYang
changed the title
This was
linked to
issues
Oct 28, 2024
|
Looks good! Most of my comments are about optimizations for dataloaders and avoiding pulling from attributes over a connection. Assuming we will address these as follow-ups. Would be good to get a frontend review here as well. |
axiomofjoy
approved these changes
Oct 28, 2024
src/phoenix/db/migrations/versions/4ded9e43755f_create_project_sessions_table.py
Show resolved
Hide resolved
Comment on lines
+54
to
+55
| models.Span.attributes[INPUT_VALUE].label("value"), | ||
| models.Span.attributes[INPUT_MIME_TYPE].label("mime_type"), |
There was a problem hiding this comment.
Non-blocking: We might want to think about materializing the input and output as their own columns so we can avoid querying attributes over a connection. Even with a dataloader, this led to performance issues with traces when the attributes are large.
This was
linked to
issues
Oct 28, 2024
RogerHYang
added a commit
that referenced
this pull request
Oct 28, 2024
RogerHYang
added a commit
that referenced
this pull request
Oct 29, 2024
RogerHYang
added a commit
that referenced
this pull request
Oct 31, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 5, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 7, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 13, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 13, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 18, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 21, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 25, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 25, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 26, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 2, 2024
This was referenced Dec 3, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 4, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 4, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
RogerHYang
added a commit
that referenced
this pull request
Dec 9, 2024
mikeldking
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4959
resolves #5011
resolves #5014
resolves #5058
resolves #5059
resolves #5066