Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sessions): add ability to navigate from trace to session #5229

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(sessions): add ability to navigate from trace to session #5229

merged 1 commit into from
Oct 30, 2024

Conversation

Parker-Stafford
Copy link
Contributor

resolves #5009

  • adds link to session page span details if the trace has a session associated with it
Screen.Recording.2024-10-29.at.4.26.36.PM.mov

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 29, 2024
@Parker-Stafford Parker-Stafford force-pushed the parker/5009-navigate-trace-to-session branch from 1e292e8 to 5520cc7 Compare October 29, 2024 23:29
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 29, 2024
@Arize-ai Arize-ai deleted a comment from review-notebook-app bot Oct 29, 2024
@axiomofjoy
Copy link
Contributor

love it guys ❤️

cephalization
cephalization approved these changes Oct 30, 2024
View reviewed changes
app/src/pages/trace/TraceDetails.tsx
@@ -113,7 +114,7 @@ export function TraceDetails(props: TraceDetailsProps) {
return () => {
setSearchParams(
(searchParams) => {
searchParams.delete("spanNodeId");
searchParams.delete(SELECTED_SPAN_NODE_ID_URL_PARAM);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Parker-Stafford Parker-Stafford merged commit 57a8473 into sessions2 Oct 30, 2024
3 checks passed
@Parker-Stafford Parker-Stafford deleted the parker/5009-navigate-trace-to-session branch October 30, 2024 15:53
@Parker-Stafford Parker-Stafford mentioned this pull request Oct 30, 2024
Closed
RogerHYang pushed a commit that referenced this pull request Oct 31, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
f16dd85
RogerHYang pushed a commit that referenced this pull request Nov 5, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
55e6a7f
RogerHYang pushed a commit that referenced this pull request Nov 7, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
3c458e9
RogerHYang pushed a commit that referenced this pull request Nov 13, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
5039afd
RogerHYang pushed a commit that referenced this pull request Nov 13, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
2d2f7eb
RogerHYang pushed a commit that referenced this pull request Nov 18, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
a2222cf
RogerHYang pushed a commit that referenced this pull request Nov 21, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
de0ec16
RogerHYang pushed a commit that referenced this pull request Nov 25, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
704c5fb
RogerHYang pushed a commit that referenced this pull request Nov 25, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
d13f576
RogerHYang pushed a commit that referenced this pull request Nov 26, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
33859b4
RogerHYang pushed a commit that referenced this pull request Dec 2, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
bb0772f
This was referenced Dec 3, 2024
Merged
Closed
RogerHYang pushed a commit that referenced this pull request Dec 4, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
c400b52
RogerHYang pushed a commit that referenced this pull request Dec 4, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
ff46659
RogerHYang pushed a commit that referenced this pull request Dec 9, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
4bf4e66
RogerHYang pushed a commit that referenced this pull request Dec 9, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
a942ca4
RogerHYang pushed a commit that referenced this pull request Dec 9, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
b47ad63
RogerHYang pushed a commit that referenced this pull request Dec 9, 2024
@Parker-Stafford @RogerHYang
feat(sessions): add ability to navigate from trace to session (#5229)
640c1a8
@mikeldking mikeldking mentioned this pull request Dec 9, 2024
Merged
mikeldking pushed a commit that referenced this pull request Dec 11, 2024
@Parker-Stafford @mikeldking
feat(sessions): add ability to navigate from trace to session (#5229)
015e60f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cephalization cephalization cephalization approved these changes

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Parker-Stafford @axiomofjoy @cephalization @RogerHYang