feat(sessions): add ability to navigate from trace to session #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
Parker-Stafford
force-pushed
the
parker/5009-navigate-trace-to-session
branch
from
1e292e8
to
5520cc7
Compare
dosubot
bot
added
size:M
RogerHYang
approved these changes
Oct 30, 2024
|
love it guys ❤️ |
cephalization
approved these changes
Oct 30, 2024
| @@ -113,7 +114,7 @@ export function TraceDetails(props: TraceDetailsProps) { | |||
| return () => { | |||
| setSearchParams( | |||
| (searchParams) => { | |||
| searchParams.delete("spanNodeId"); | |||
| searchParams.delete(SELECTED_SPAN_NODE_ID_URL_PARAM); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5009
Screen.Recording.2024-10-29.at.4.26.36.PM.mov