Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(playground): use context manager for creating playground llm spans #5242

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor(playground): use context manager for creating playground llm spans #5242

wants to merge 5 commits into from
+174 −139

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Oct 31, 2024 •
edited
Loading

  • dry things out a bit by using a context manager for creating llm spans
  • remove ChatCompletionSubscriptionError type

resolves #5241

@axiomofjoy axiomofjoy marked this pull request as ready for review October 31, 2024 07:55
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
phoenix
Status: 📘 Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[playground] llm span context manager
1 participant
@axiomofjoy