Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sessions): filter sessions on root spans via substring search #5257

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

RogerHYang
Copy link
Contributor

resolves #5007
resolves #5013

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 1, 2024
@RogerHYang RogerHYang changed the title Sessions search on root span feat(sessions): filter sessions on root spans Nov 1, 2024
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RogerHYang RogerHYang changed the title feat(sessions): filter sessions on root spans feat(sessions): filter sessions on root spans via substring search Nov 4, 2024
app/schema.graphql Outdated Show resolved Hide resolved
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"name": "python"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops how do i clean these before pushing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can install pre-commit

pip install pre-commit

@RogerHYang RogerHYang merged commit 1ecd28e into sessions2 Nov 4, 2024
31 checks passed
@RogerHYang RogerHYang deleted the sessions-search-on-root-span branch November 4, 2024 22:33
RogerHYang added a commit that referenced this pull request Nov 5, 2024
RogerHYang added a commit that referenced this pull request Nov 7, 2024
RogerHYang added a commit that referenced this pull request Nov 13, 2024
RogerHYang added a commit that referenced this pull request Nov 13, 2024
RogerHYang added a commit that referenced this pull request Nov 18, 2024
RogerHYang added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[sessions][gql] session search parameter [sessions][ui] search field
3 participants