feat(sessions): only recognize session id on root span (where parent is null) #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
RogerHYang
changed the title
axiomofjoy
reviewed
Nov 13, 2024
| if span.parent_id is None: | ||
| session_id = get_attribute_value(span.attributes, SpanAttributes.SESSION_ID) | ||
| session_user = get_attribute_value(span.attributes, SpanAttributes.USER_ID) | ||
| if session_id is not None and (not isinstance(session_id, str) or session_id.strip()): |
There was a problem hiding this comment.
Suggested change
| if session_id is not None and (not isinstance(session_id, str) or session_id.strip()): | |
| if session_id is not None: |
Is the second part of the conditional necessary?
There was a problem hiding this comment.
technically it's possible to have "" (empty string) as the session.id, do we want to record that?
There was a problem hiding this comment.
I see. Probably not would be my guess.
axiomofjoy
approved these changes
Nov 13, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 18, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 21, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 25, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5347