Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embeddings): properly attribute points as unknown correctness when predictions/actuals are missing #558

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Apr 10, 2023

resolves #523

For now the UI renders all points as "unknown" correctness. I think there's probably some optimization we can do when actuals are missing but for now this at least renders a point-cloud
Screenshot 2023-04-10 at 10 48 42 AM

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mikeldking mikeldking merged commit 7f6d654 into main Apr 10, 2023
@mikeldking mikeldking deleted the fix/color-by-correctness-unknown branch April 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] If no actual_label is provided, color by correctness results in an empty view
2 participants