Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore non-vectors for embeddings #584

Merged
merged 4 commits into from
Apr 12, 2023
Merged

fix: ignore non-vectors for embeddings #584

merged 4 commits into from
Apr 12, 2023

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Apr 12, 2023 •
edited
Loading

resolves #572

alternative approaches

  • isinstance(..., collections.abc.Sized)
    • this one makes mypy really upset
  • try: len(...) and except TypeError:
    • works but more cumbersome

@RogerHYang RogerHYang merged commit 0bfbfa1 into main Apr 12, 2023
@RogerHYang RogerHYang deleted the ignore-non-vectors branch April 12, 2023 20:54
fjcasti1 pushed a commit that referenced this pull request Apr 18, 2023
Merge branch 'main' into enable-generative
d8aaac6 
* main:
  v0.0.13
  fix: don't compile js/html if exists - unblock conda (#597)
  docs: credit card fraud tutorial notebook update (#555)
  docs: update quickstart notebook (#564)
  don't raise error during dimension type inference (#596)
  fix: Update pyproject.toml (#595)
  chore: change https to http for downloading fixtures and example datasets (#589)
  chore: Use pre commit for prettier and eslint (#588)
  ci: Create .github/dependabot.yml (#587)
  chore: create SECURITY.md (#586)
  chore: legal info (#583)
  fix: ignore non-vectors for embeddings (#584)
  chore: bump to typescript 5 (#585)
  v0.0.12
  feat(embeddings): grid view improvements: sizes, multi-modal output (#565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
phoenix
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Phoenix crashes with list of nans in embedding vector column
2 participants
@RogerHYang @mikeldking