-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the native logger "show if shell visible" setting default. #173
Comments
I've got a better plan, now a default config file will be added to the plugin's folder, what do you think of it? |
That is an even better idea and would work perfectly. |
I'm afraid it might have a negative impact on git submodule routine, which I consider as very valuable feature of panku plugin. User settings should not affect git status of your project, and it works perfectly right now. Obvious workaround is to make panku config file path customizable in godot project settings. Not sure if is it easy to implement though. |
now a rough solution is: whenever
[quit] save everything to |
Decent solution overall, but a couple minor inconvenience can be spotted.
How will user do config changes when file located in
That means when you are switching from I would consider slightly tweaked workflow like: Whenever
[quit] Save everything to file defined in step 1 (we can repeat call |
* feat: custom default config file refers to: #173 * Update addons/panku_console/common/config.gd Co-authored-by: worron <worrongm@gmail.com> --------- Co-authored-by: worron <worrongm@gmail.com>
* feat: custom default config file refers to: Ark2000/PankuConsole#173 * Update addons/panku_console/common/config.gd Co-authored-by: worron <worrongm@gmail.com> --------- Co-authored-by: worron <worrongm@gmail.com> (Ark2000/PankuConsole@6e8ad31))
Is your feature request related to a problem? Please describe.
I really want to leave the console in the exported build. But the problem is, the logger is always visible by default. I could just change the settings, but these are stored in the user folder, which means that they don't transfer across devices.
Describe the solution you'd like
Make the native logger "show if shell visible" setting default.
The text was updated successfully, but these errors were encountered: