Rework variable tracker module #153
Conversation
Module refactored to handle situation where no current active scene available, only singletons in the tree. Singleton detection changed to use project settings data. Current scene tracking loop delay moved to module settings and now can be configured by user.
|
Thank you for your contribution! seems it is a much improved version, I'll check it out later. |
| ## Find the root node of current active scene. | ||
| func get_scene_root() -> Node: | ||
| # Assuming current scene is the first node in tree that is not autoload singleton. | ||
| for node:Node in core.get_tree().root.get_children(): |
There was a problem hiding this comment.
Seems it's a new feature of Godot4.2, however we want to keep backwards compatibility, please use syntax like this to simulate a typed for loop:
for _node in xxx:
var node:Node = _node
# ...There was a problem hiding this comment.
Ok, I think we can simply go without typed loop variable then.
| func _check_autoloads() -> void: | ||
| var _user_singleton_names := [] | ||
|
|
||
| for node:Node in core.get_tree().root.get_children(): |
There was a problem hiding this comment.
same review comment as previous one.
| if core.module_manager.has_module(SHELL_MODULE_NAME): | ||
| var ishell = core.module_manager.get_module(SHELL_MODULE_NAME) | ||
| ishell.interactive_shell.output(message) | ||
|
|
There was a problem hiding this comment.
print something to dev console should be improved later in 1.9.0 to avoid unnecessary setup.
| return true | ||
|
|
||
| return false | ||
|
|
There was a problem hiding this comment.
So, there's actually no elegant way to get a list of running autoload singletons...
There was a problem hiding this comment.
Unfortunately, I just can't find anything better so far.
|
The pr solved an issue also, #154. It seems that you are already well acquainted with the code base. I'm excited to see more of your contributions in the future! |
|
Fixes done. |
First of all, thank you for sharing your work, this tool is amazing. Unfortunately my project has a bit tricky structure, sometime there is not a main scene loaded, only singletons placed in the tree. Current implementation of
variable_trackercan't handle such situations, so I made a deep rework of the module for my needs. Please take a look at the code, may be you will be interested in approving it into your project.Main changes: