Add option to auto disable console on release #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use custom EditorExportPlugin to auto disable panku singleton in release builds. This feature disabled by default should not affect existing installations. Can be activated by project setting option.
|
Thank you for your contribution! I'll check it out later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I was trying to automatize console disabling for my release builds. Only option was found so far uses
EditorExportPluginand require lots of changes inplugin.gd(Am I missing any easy solutions?). Please take a look at the code, may be you will be interested in this feature in upstream. The feature totally optional, disabled by default, and can be activated thoughpankuspecific project settings.The code feels a bit bloated though, feel free to decline if you have any concerns.