Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tricks for current scene detection #172

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

worron
Copy link
Collaborator

@worron worron commented Apr 22, 2024

This PR addressing #171 problem. Since current scene detection algorithm kinda weak, I propose few extra settings in variable tracker module to control it.

  • Setting to use last top level node as current scene instead of first one. This solution was mentioned in related issue, but lets make it optional just in case.
  • Setting to which allows to manually configure exceptions, top level nodes straight up ignored by variable tracker. This also allows to avoid flooding console namespace in project with many singletons.

worron added 2 commits April 22, 2024 16:06
Extra option in variable tracker module settings
allows to pick last root node as current scene.
Such behavior seems more fail-safe and enabled
by default now. It's still optional just in case.
Add option to variable tracker settings
which allows to set some ignored top level nodes.
@Ark2000 Ark2000 merged commit 52555ad into Ark2000:master Apr 23, 2024
@worron worron deleted the current_scene_detection branch April 23, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants