Move config settings and checks to related module #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move some config constants and functions from main plugin module to settings module. This should help with some glitches when settings module can't call main plugin module in runtime.
|
@TheContainer, Can you give it a test please? |
I ran multiple tests I created earlier where the errors occurred, and every test worked fine. |
|
Sorry for the late reply, I tested it and it works fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #177.
Was found that sometimes calling main plugin class
PankuConsolePluginfrom config module lead to fails in runtime. Happened in exported project reliably and in editor randomly, but later hard to reproduce. As fast solution I tried to move config related code toPankuConfigmodule and call it from plugin module, and seems it woks fine.Not sure if it's optimal solution but still suggesting to use it as quick fix.