Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-blockchain): increase coverage to 100% #3604

Merged
merged 11 commits into from
Mar 24, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Mar 19, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3604 into develop will increase coverage by 6.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3604      +/-   ##
===========================================
+ Coverage    80.78%   87.55%   +6.76%     
===========================================
  Files          439      439              
  Lines        10121    10121              
  Branches      1301     1301              
===========================================
+ Hits          8176     8861     +685     
+ Misses        1941     1256     -685     
  Partials         4        4              
Impacted Files Coverage Δ
...ssor/handlers/incompatible-transactions-handler.ts 100.00% <ø> (+100.00%) ⬆️
...c/processor/handlers/nonce-out-of-order-handler.ts 100.00% <ø> (+100.00%) ⬆️
packages/core-blockchain/src/blockchain.ts 100.00% <100.00%> (+100.00%) ⬆️
packages/core-blockchain/src/service-provider.ts 100.00% <0.00%> (+100.00%) ⬆️
...kages/core-blockchain/src/state-machine/machine.ts 100.00% <0.00%> (+100.00%) ⬆️
...s/core-blockchain/src/processor/block-processor.ts 100.00% <0.00%> (+100.00%) ⬆️
...core-blockchain/src/state-machine/state-machine.ts 100.00% <0.00%> (+100.00%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937ffa0...3827e49. Read the comment docs.

@air1one air1one changed the title test(core blockchain): 100% unit tests coverage test(core-blockchain): 100% unit tests coverage Mar 19, 2020
@faustbrian faustbrian changed the title test(core-blockchain): 100% unit tests coverage test(core-blockchain): increase coverage to 100% Mar 20, 2020
@air1one air1one marked this pull request as ready for review March 24, 2020 09:02
@faustbrian faustbrian merged commit 6c8c436 into develop Mar 24, 2020
@ghost ghost deleted the test/core-blockchain-3.0 branch March 24, 2020 10:17
@ghost ghost removed the Status: Needs Review label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants