Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-forger): log warning when active delegates are under the required delegate count #3611

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

bertiespell
Copy link
Contributor

Summary

Log a warning in the DelegateTracker's handle method when the number of active delegates is below the required delegate count.

Without the total number of required delegates we are not able to accurately compute the next forgers.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #3611 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3611      +/-   ##
===========================================
+ Coverage    80.77%   80.78%   +<.01%     
===========================================
  Files          439      439              
  Lines        10119    10121       +2     
  Branches      1300     1301       +1     
===========================================
+ Hits          8174     8176       +2     
  Misses        1941     1941              
  Partials         4        4
Impacted Files Coverage Δ
packages/core-forger/src/delegate-tracker.ts 100% <0%> (ø) ⬆️
packages/core-transactions/src/utils.ts 100% <0%> (ø) ⬆️
packages/core-forger/src/errors.ts 100% <0%> (ø) ⬆️
.../core-state/src/wallets/wallet-repository-clone.ts 100% <0%> (ø) ⬆️
packages/core-state/src/wallets/wallet.ts 100% <0%> (ø) ⬆️
...ackages/core-magistrate-transactions/src/errors.ts 100% <0%> (ø) ⬆️
packages/core-logger-pino/src/driver.ts 100% <0%> (ø) ⬆️
packages/core-forger/src/methods/bip38.ts 100% <0%> (ø) ⬆️
...ages/core-transactions/src/handlers/transaction.ts 100% <0%> (ø) ⬆️
...ages/core-kernel/src/services/schedule/cron-job.ts 100% <0%> (ø) ⬆️
... and 306 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5fead...9b1cb5f. Read the comment docs.

@faustbrian faustbrian merged commit 937ffa0 into develop Mar 23, 2020
@ghost ghost deleted the fix/core-forger/active-delegate-count branch March 23, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants