fix(core-test-framework): change import scope from @package to @arkecosystem #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KovacZan
requested review from
air1one,
faustbrian and
kristjank
as code owners
faustbrian
changed the title
faustbrian
approved these changes
Mar 24, 2020
faustbrian
changed the title
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What changes are being made?
Changed
import { Services } from "@packages/core-kernel";to
import { Services } from "@arkecosystem/core-kernel";Why are these changes necessary?
When writing tests for custom-transaction in plugins folder I received the following error:
● Test suite failed to run Cannot find module '@packages/core-kernel' from 'wallet.ts'Checklist