-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-test-framework): add reusable mocks from tests #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-framework, core-transactions, core-magistrate-crypto): prettier and lint
…ng from @packages and lint
…mock folder from test
…re-test-framework
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
March 27, 2020 11:38
ghost
added
the
Complexity: Undetermined
label
Mar 27, 2020
faustbrian
changed the title
Refactor/tests
feat(core-test-framework): add reusable mocks from tests
Mar 27, 2020
sebastijankuzner
force-pushed
the
refactor/tests
branch
from
March 27, 2020 13:28
384aee8
to
2de5cec
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3621 +/- ##
============================================
+ Coverage 13.18% 91.35% +78.17%
============================================
Files 439 451 +12
Lines 10074 10205 +131
Branches 1289 1304 +15
============================================
+ Hits 1328 9323 +7995
+ Misses 8724 880 -7844
+ Partials 22 2 -20
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Mar 28, 2020
ghost
deleted the
refactor/tests
branch
March 28, 2020 08:13
ghost
mentioned this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add mock classes and transaction to database model mapper inside core-test-framework.
Add tests for new classes.
Rafactor existing tests to use new mock classes.
Rafactor exisitng tests to use assets and lint files.
Checklist