Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-test-framework): add reusable mocks from tests #3621

Merged
merged 15 commits into from
Mar 28, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

Add mock classes and transaction to database model mapper inside core-test-framework.
Add tests for new classes.
Rafactor existing tests to use new mock classes.
Rafactor exisitng tests to use assets and lint files.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@faustbrian faustbrian changed the title Refactor/tests feat(core-test-framework): add reusable mocks from tests Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #3621 into develop will increase coverage by 78.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3621       +/-   ##
============================================
+ Coverage    13.18%   91.35%   +78.17%     
============================================
  Files          439      451       +12     
  Lines        10074    10205      +131     
  Branches      1289     1304       +15     
============================================
+ Hits          1328     9323     +7995     
+ Misses        8724      880     -7844     
+ Partials        22        2       -20     
Impacted Files Coverage Δ
.../core-test-framework/src/mocks/block-repository.ts 100.00% <100.00%> (ø)
...ckages/core-test-framework/src/mocks/blockchain.ts 100.00% <100.00%> (ø)
...s/core-test-framework/src/mocks/network-monitor.ts 100.00% <100.00%> (ø)
...ages/core-test-framework/src/mocks/peer-storage.ts 100.00% <100.00%> (ø)
packages/core-test-framework/src/mocks/query.ts 100.00% <100.00%> (ø)
.../core-test-framework/src/mocks/round-repository.ts 100.00% <100.00%> (ø)
...framework/src/mocks/service-provider-repository.ts 100.00% <100.00%> (ø)
...kages/core-test-framework/src/mocks/state-store.ts 100.00% <100.00%> (ø)
...-framework/src/mocks/transaction-pool-processor.ts 100.00% <100.00%> (ø)
...test-framework/src/mocks/transaction-repository.ts 100.00% <100.00%> (ø)
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1299551...6ef5bd5. Read the comment docs.

@faustbrian faustbrian merged commit a82a094 into develop Mar 28, 2020
@ghost ghost deleted the refactor/tests branch March 28, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants