test(core): increase coverage to 100% #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive a valid bip38
…only prompts (not flags)
bertiespell
requested review from
air1one,
faustbrian and
kristjank
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3623 +/- ##
========================================
Coverage 93.18% 93.18%
========================================
Files 451 451
Lines 10202 10202
Branches 1301 1301
========================================
Hits 9507 9507
Misses 694 694
Partials 1 1 Continue to review full report at Codecov.
|
ghost
mentioned this pull request
faustbrian
reviewed
Mar 30, 2020
faustbrian
reviewed
Mar 30, 2020
| if (this.hasFlag("token")) { | ||
| this.config.set("token", this.getFlag("token")); | ||
| } | ||
| // TODO: check |
There was a problem hiding this comment.
That must've been a copy & paste mistake on my end when I created the command. Since this is a command to alter the configuration nothing should have a default value which means token could actually be empty.
faustbrian
reviewed
Mar 30, 2020
faustbrian
reviewed
Mar 30, 2020
faustbrian
reviewed
Mar 30, 2020
|
@bertiespell conflicts |
faustbrian
approved these changes
Mar 30, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase test coverage in the core package to 100%
Checklist