-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-manager): dispatch wallet events #3776
Conversation
new Services.Attributes.AttributeMap( | ||
context.container.get<Services.Attributes.AttributeSet>(Container.Identifiers.WalletAttributes), | ||
if (!app.isBound(Container.Identifiers.WalletFactory)) { | ||
app.bind(Container.Identifiers.WalletFactory).toFactory<Contracts.State.Wallet>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use rebind
to avoid any issues because core-manager
will usually be loaded after the WalletFactory
has already been bound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it, but the problem is, because core-manager needs to be loaded right after core-logger-pino, otherwise the half of the logs (from classes created in register mehtod) are missing. We need to replace log service with LogServiceWrapper before other classes are created.
Codecov Report
@@ Coverage Diff @@
## develop #3776 +/- ##
===========================================
- Coverage 89.40% 87.80% -1.61%
===========================================
Files 615 617 +2
Lines 13558 13591 +33
Branches 1527 1533 +6
===========================================
- Hits 12121 11933 -188
- Misses 313 525 +212
- Partials 1124 1133 +9
Continue to review full report at Codecov.
|
Summary
This PR introduces new WatcherWallet, which is inherited Wallet with ability to dispatch events on every attribute or property change. When using core-manager original wallet factory is replaced with custom factory which return wallet proxies.
Checklist