Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transaction-pool): handle transaction deserialize error #3793

Merged

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 12, 2020

Summary

Fix error seen in #3792. Transaction deserialization error wasn't handled properly.

Checklist

  • Ready to be merged

@ghost ghost added Complexity: Low labels Jun 12, 2020
@rainydio rainydio changed the title fix(core-transaction-pool): fix processor deserialize fix(core-transaction-pool): handle transaction deserialize error Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #3793 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3793   +/-   ##
========================================
  Coverage    96.92%   96.92%           
========================================
  Files          616      616           
  Lines        13999    14002    +3     
  Branches      1688     1688           
========================================
+ Hits         13569    13572    +3     
  Misses         137      137           
  Partials       293      293           
Flag Coverage Δ
#functional 6.39% <0.00%> (-0.01%) ⬇️
#integration 10.09% <0.00%> (-0.01%) ⬇️
#unit 94.92% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...ansactions/src/handlers/bridgechain-resignation.ts 96.66% <ø> (ø)
...te-transactions/src/handlers/bridgechain-update.ts 93.82% <ø> (ø)
...sactions/src/handlers/one/delegate-registration.ts 89.36% <ø> (ø)
.../src/handlers/one/second-signature-registration.ts 93.75% <ø> (ø)
...ges/core-transactions/src/handlers/one/transfer.ts 91.66% <ø> (ø)
...ackages/core-transactions/src/handlers/one/vote.ts 90.90% <ø> (ø)
...nsactions/src/handlers/two/delegate-resignation.ts 97.67% <ø> (ø)
...s/core-transactions/src/handlers/two/htlc-claim.ts 92.70% <ø> (ø)
.../core-transactions/src/handlers/two/htlc-refund.ts 90.36% <ø> (ø)
...s/src/handlers/two/multi-signature-registration.ts 90.90% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507f811...ce13f7d. Read the comment docs.

@faustbrian faustbrian merged commit 09e0892 into develop Jun 17, 2020
@ghost ghost deleted the fix/core-transaction-pool/fix-processor-deserialize branch June 17, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants