fix(core-database): fix round order #3816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While checking block generator block processor loads round from database, but rows aren't guaranteed to be ordered. There is no built-in guarantee in db on which order rows will come out. Usually they are in order they were added, but it might be mixed.
New
RoundRepository.getRound
method returns rows the same way they were sorted when list of round delegates was built ordered bybalance desc, public_key asc
.Equivalent to:
Checklist