-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-p2p): include estimateTotalCount into peers response #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
June 23, 2020 14:08
ghost
added
Complexity: Low
labels
Jun 23, 2020
Codecov Report
@@ Coverage Diff @@
## develop #3825 +/- ##
===========================================
+ Coverage 91.87% 92.00% +0.13%
===========================================
Files 620 620
Lines 14787 14798 +11
Branches 1853 1850 -3
===========================================
+ Hits 13585 13615 +30
+ Misses 938 937 -1
+ Partials 264 246 -18
Continue to review full report at Codecov.
|
faustbrian
changed the title
feat(core-p2p, core-api): include estimateTotalCount into peers response
feat(core-p2p): include estimateTotalCount into peers response
Jun 23, 2020
faustbrian
reviewed
Jun 25, 2020
ghost
mentioned this pull request
Jun 28, 2020
air1one
approved these changes
Jun 29, 2020
ghost
deleted the
feat/core-api/estimateTotalCount
branch
June 29, 2020 09:03
ghost
mentioned this pull request
Jul 5, 2020
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves issue #3592.
P2P API includes estimateTotalCount boolean property based on the node configuration achieved via CORE_API_NO_ESTIMATED_TOTAL_COUNT flag.
Core-api peers endpoint now returns plugins with the estimateTotalCount property inside @arkecosystem/core-api plugin options.
Part of the response:
Checklist