-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crypto): transaction builder should build and sign versioned transactions #3831
Conversation
…ransaction-version-defaults
Codecov Report
@@ Coverage Diff @@
## develop #3831 +/- ##
===========================================
+ Coverage 91.87% 91.99% +0.11%
===========================================
Files 620 620
Lines 14787 14795 +8
Branches 1853 1849 -4
===========================================
+ Hits 13585 13610 +25
Misses 938 938
+ Partials 264 247 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just rename versionSpecified
to something like disableVersionCheck
so that we have a better idea of what the parameter does.
Summary
This updates the
TransactionBuilder
to successfully build and sign transactions when the version number has been specifically set.Better dx - if the version has been specifically set on the transaction, we would not expect the Builder to throw a
TransactionVersionError
. As requested in #3099Adds a flag to check to de/serialisation options
Checklist