-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core-transactions): stream transactions during bootstrap #3844
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3844 +/- ##
===========================================
- Coverage 92.14% 92.09% -0.06%
===========================================
Files 621 620 -1
Lines 14826 14845 +19
Branches 1831 1847 +16
===========================================
+ Hits 13662 13671 +9
+ Misses 952 951 -1
- Partials 212 223 +11
Continue to review full report at Codecov.
|
It appears as coverage errors are false-positives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the comments and we're good 👍
Summary
Bootstrap implementations that used reader were limited to
1000000000
transactions only. There was a comment mentioning that and suggesting to use streams.streamByCriteria
method was added to transaction history service.getTransactionReader
was removed from base transaction handler.multiSignature.legacy
set by legacy multi-signature handler.Checklist