-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core-magistrate-transactions): entity handler bootstrap method, fetch transactions using asset type/subType as number #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
labels
Jun 29, 2020
Codecov Report
@@ Coverage Diff @@
## develop #3852 +/- ##
============================================
+ Coverage 12.83% 92.17% +79.34%
============================================
Files 620 620
Lines 14840 14850 +10
Branches 1842 1844 +2
============================================
+ Hits 1904 13688 +11784
+ Misses 12823 948 -11875
- Partials 113 214 +101
Continue to review full report at Codecov.
|
air1one
changed the title
test(functional): add state builder test to each functional test
fix(core-magistrate-transactions): entity handler bootstrap method, fetch transactions using asset type/subType as number
Jul 2, 2020
rainydio
reviewed
Jul 2, 2020
__tests__/unit/core-transactions/handlers/two/htlc-claim.test.ts
Outdated
Show resolved
Hide resolved
rainydio
approved these changes
Jul 2, 2020
faustbrian
approved these changes
Jul 2, 2020
ghost
deleted the
test/functional/state-builder
branch
July 2, 2020 15:55
ghost
mentioned this pull request
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity handler bootstrap method was fetching transactions using asset type/subType as string, resulting in no transaction fetched at all.
Also refactored htlc handlers to remove htlc attribute when there is no more lock for the wallet.
Added state builder run() test to each functional test to check that it would rebuild the same wallets state that was built from running the functional tests.