Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-transaction-pool): union query typeGroup with number #3854

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

rainydio
Copy link
Contributor

Summary

Union typeGroup with number so that pool can be queried from other packages.

Checklist

  • Ready to be merged

@ghost ghost added the Complexity: Low label Jun 30, 2020
@rainydio rainydio changed the title Change typeGroup to union with number refactor(core-transaction-pool): union typeGroup with number Jun 30, 2020
@rainydio rainydio changed the title refactor(core-transaction-pool): union typeGroup with number refactor(core-transaction-pool): union query typeGroup with number Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #3854 into develop will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3854      +/-   ##
===========================================
+ Coverage    89.18%   89.48%   +0.29%     
===========================================
  Files          620      620              
  Lines        14816    14816              
  Branches      1852     1852              
===========================================
+ Hits         13214    13258      +44     
+ Misses        1377     1291      -86     
- Partials       225      267      +42     
Flag Coverage Δ
#functional 6.08% <ø> (+0.14%) ⬆️
#integration 9.57% <ø> (ø)
#unit 85.41% <ø> (-1.90%) ⬇️
Impacted Files Coverage Δ
packages/core-transaction-pool/src/query.ts 100.00% <ø> (ø)
...ages/core-test-framework/src/internal/delegates.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-test-framework/src/cli/console.ts 9.52% <0.00%> (-80.96%) ⬇️
packages/core-test-framework/src/utils/mapper.ts 20.00% <0.00%> (-80.00%) ⬇️
...mework/src/matchers/blockchain/execute-on-entry.ts 20.00% <0.00%> (-80.00%) ⬇️
...kages/core-test-framework/src/matchers/api/peer.ts 23.07% <0.00%> (-76.93%) ⬇️
...ages/core-test-framework/src/matchers/api/block.ts 23.07% <0.00%> (-76.93%) ⬇️
...ackages/core-test-framework/src/internal/signer.ts 14.28% <0.00%> (-73.02%) ⬇️
...test-framework/src/mocks/transaction-repository.ts 27.27% <0.00%> (-72.73%) ⬇️
...test-framework/src/matchers/blockchain/dispatch.ts 14.28% <0.00%> (-71.43%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a7176...e327877. Read the comment docs.

@faustbrian faustbrian merged commit 1a81aee into develop Jun 30, 2020
@faustbrian faustbrian deleted the fix/core-transaction-pool/query-type-group branch June 30, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants