-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-p2p): remove excess code from hapi-nes #3878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core-kernel/src/contracts/p2p/nes-client.ts
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
July 6, 2020 16:40
ghost
added
Complexity: High
labels
Jul 6, 2020
Codecov Report
@@ Coverage Diff @@
## develop #3878 +/- ##
===========================================
+ Coverage 91.93% 94.22% +2.28%
===========================================
Files 616 616
Lines 14793 14421 -372
Branches 1842 1733 -109
===========================================
- Hits 13600 13588 -12
+ Misses 976 616 -360
Partials 217 217
Continue to review full report at Codecov.
|
air1one
approved these changes
Jul 7, 2020
ghost
deleted the
refactor/core-p2p/hapi-nes
branch
July 7, 2020 07:59
ghost
mentioned this pull request
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves issue #3868.
Checklist