-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core-database): guaranteed transaction order #3879
Merged
air1one
merged 8 commits into
develop
from
fix/core-database/guaranteed-transaction-order
Jul 9, 2020
Merged
fix(core-database): guaranteed transaction order #3879
air1one
merged 8 commits into
develop
from
fix/core-database/guaranteed-transaction-order
Jul 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
labels
Jul 8, 2020
Codecov Report
@@ Coverage Diff @@
## develop #3879 +/- ##
========================================
Coverage 94.22% 94.23%
========================================
Files 616 617 +1
Lines 14421 14440 +19
Branches 1733 1736 +3
========================================
+ Hits 13588 13607 +19
Misses 616 616
Partials 217 217
Continue to review full report at Codecov.
|
air1one
approved these changes
Jul 9, 2020
ghost
deleted the
fix/core-database/guaranteed-transaction-order
branch
July 9, 2020 09:12
ghost
removed
the
Status: Needs Review
label
Jul 9, 2020
ghost
mentioned this pull request
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3870. Takes 30m to execute migration that adds
block_height
column.Checklist