This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
refactor: updates for compatibility with Core v3 #2944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
Less than 64 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Status: In Progress
The issue or pull request is being worked on.
labels
Oct 7, 2020
luciorubeens
changed the title
fix: use addresses as query param
refactor: updates for compatibility with Core v3
Oct 7, 2020
luciorubeens
force-pushed
the
feat/v3-api
branch
from
October 10, 2020 20:38
3d7c069
to
116e09a
Compare
ghost
mentioned this pull request
Oct 11, 2020
luciorubeens
requested review from
alexbarnsley,
faustbrian and
ItsANameToo
as code owners
November 11, 2020 16:20
ghost
added
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
and removed
Status: In Progress
The issue or pull request is being worked on.
labels
Nov 11, 2020
ItsANameToo
approved these changes
Nov 12, 2020
not sure if we need a new release once it's merged as it's only useful for v3 on devnet right @luciorubeens ? Since no additional features / fixes are incorporated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Low
Less than 64 lines changed.
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist