Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: updates for compatibility with Core v3 #2944

Merged
merged 11 commits into from
Nov 12, 2020
Merged

Conversation

luciorubeens
Copy link
Contributor

@luciorubeens luciorubeens commented Oct 7, 2020

Summary

  • Sanitize the attributes field
  • Use address as query param

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Oct 7, 2020
@luciorubeens luciorubeens changed the title fix: use addresses as query param refactor: updates for compatibility with Core v3 Oct 7, 2020
@luciorubeens luciorubeens marked this pull request as ready for review November 11, 2020 16:20
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Nov 11, 2020
@ItsANameToo
Copy link
Member

not sure if we need a new release once it's merged as it's only useful for v3 on devnet right @luciorubeens ? Since no additional features / fixes are incorporated

@luciorubeens luciorubeens merged commit 8d71c5c into 2.0 Nov 12, 2020
@luciorubeens luciorubeens deleted the feat/v3-api branch November 12, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Status: Needs Review The issue or pull request needs a review by a developer of the team. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants