fix: enable vendorfield for multipayment #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dated
requested review from
faustbrian,
ItsANameToo,
kristjank and
spkjp
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
ghost
mentioned this pull request
kristjank
approved these changes
Jan 15, 2020
ghost
added
the
Status: Member Approved
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
kristjank
added
the
Bounty: Tier 5
|
Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem. |
ghost
mentioned this pull request
kristjank
pushed a commit
that referenced
this pull request
Feb 12, 2020
* feat: add AIP11 transaction types (#56) * chore(deps): update dependency gradle to v5 (#62) * release: 0.1.4 (#47) * chore: bump dependencies (#49) * release: 0.1.5 (#50) * chore: downgrade bitcoinj-core to 0.14.7 (#51) * release: 0.1.6 (#52) * chore: setup probot/stale configuration * chore(readme): add lead maintainer information (#54) * ci: setup github action workflow for testing * ci: adjust job triggers (#58) * ci: report coverage to codecov (#59) * chore(deps): add renovate.json (#60) * chore(deps): update dependency gradle to v5 * refactor: add SpotlessPlugin and make required changes (#64) * refactor: change transactionType in abstract builder into int (#68) * chore: spotless plugin can only run with java 8 (#76) * chore: remove throw statement if spotless is not run on java 8 (#78) * style: rename AbstractTransaction to AbstractTransactionBuilder (#79) * fix: enable vendorfield for multipayment (#81) * fix: enable vendorfield for multipayment * test: add vendorField to test multipayment txs * chore: spotless plugin (#83) Co-authored-by: Kristjan Kosic <chris@ark.io> * chore: merge master into develop (#86) * release: 0.1.4 (#47) * chore: bump dependencies (#49) * release: 0.1.5 (#50) * chore: downgrade bitcoinj-core to 0.14.7 (#51) * release: 0.1.6 (#52) * chore: setup probot/stale configuration * chore(readme): add lead maintainer information (#54) * ci: setup github action workflow for testing * ci: adjust job triggers (#58) * ci: report coverage to codecov (#59) * chore(deps): add renovate.json (#60) * chore: update workflow config (#66) * chore(deps): update dependency gradle to v6 (#70) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency com.google.code.gson:gson to v2.8.6 (#71) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency org.bitcoinj:bitcoinj-core to v0.15.6 (#72) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency org.bouncycastle:bcprov-jdk15on to v1.64 (#73) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * fix: handle SignatureDecodeException (#85) * fix: handle SignatureDecodeException * fix: exception handling in Message.java re: update bitcoinj * fix: remove bouncy castle from deps // collision with bitcoinj * chore: update guava package * style: spotless * style: spotless included now in test folder to * chore(deps): update dependency gradle to v6.1.0 (#87) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(test): added actions for different java versions * Revert "chore(test): added actions for different java versions" This reverts commit 71db89a. * chore: add actions for different JDK versions (#90) Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com> Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Edgar Goetzendorff <hello@dated.fun> Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * Update HTLC claim to support secret of 32 bytes (#97) * feat: added a task to build standalone jars (#99) * fix: multipay serde fix and additional tests (#101) * fix: toJson to accomodate for BigNums * tests: additional helper tests * fix: vendorField serialization * lint: spotless * test: new fixtures for ecdsa and fix for multipayment serde (#102) * chore: .gitignore * chore: .gitignore for idea * fix: multipayment serde * test: new generated fixtures (ecds) * test: fixed test multipayment serde - use new fixtures * test: fix transfer tests - migrate to new fixtures * test: delegate registration to new fixures * test: fix tests, move to new fixtures * test: serde tests to new ecdsa fixtures * test: moving to new fixtures * fix: second signature registration serde methods (#103) * style: spotless apply * release: sync branches (#104) * release: 0.1.4 (#47) * chore: bump dependencies (#49) * release: 0.1.5 (#50) * chore: downgrade bitcoinj-core to 0.14.7 (#51) * release: 0.1.6 (#52) * chore: setup probot/stale configuration * chore(readme): add lead maintainer information (#54) * ci: setup github action workflow for testing * ci: adjust job triggers (#58) * ci: report coverage to codecov (#59) * chore(deps): add renovate.json (#60) * chore: update workflow config (#66) * chore(deps): update dependency gradle to v6 (#70) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency com.google.code.gson:gson to v2.8.6 (#71) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency org.bitcoinj:bitcoinj-core to v0.15.6 (#72) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency org.bouncycastle:bcprov-jdk15on to v1.64 (#73) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * fix: handle SignatureDecodeException (#85) * fix: handle SignatureDecodeException * fix: exception handling in Message.java re: update bitcoinj * fix: remove bouncy castle from deps // collision with bitcoinj * chore: update guava package * chore(deps): update dependency gradle to v6.1.0 (#87) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore: add actions for different JDK versions (#90) * chore(deps): update dependency org.junit.jupiter:junit-jupiter-api to v5.6.0 (#93) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency org.junit.jupiter:junit-jupiter-engine to v5.6.0 (#94) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore(deps): update dependency gradle to v6.1.1 (#95) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> Co-authored-by: Kristjan Kosic <chris@ark.io> * style: spotless apply Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com> Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Edgar Goetzendorff <hello@dated.fun> Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> * chore: changelog * chore: pom version tag Co-authored-by: KovacZan <39158639+KovacZan@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Edgar Goetzendorff <hello@dated.fun> Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com> Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com> Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provides missing method to add a vendorfield to a multipayment transaction.
Checklist