perf: use optimized base58 implementation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
per LedgerHQ CTO, the Base58 implementation in [Ledger App BTC](https://github.com/LedgerHQ/ledger-app-btc/blob/master/src/btchip_base58.c#L79 ) contains several performance optimizations and better bounds-checking. This commit implements the optimized Base58 version.
sleepdefic1t
force-pushed
the
perf/base58
branch
from
8b7c95d to
81d100e
Compare
ghost
deleted the
sleepdefic1t
added a commit
that referenced
this pull request
Feb 8, 2020
## Summary While there are no breaking changes from a users perspective, this release includes a massive rewrite of the project. Specific objectives accomplished within this release: - Support ARK Core v2 Transactions. - Support Message Signing. - Merge changes from `LedgerHQ/ledger-app-ark`. - Update the ARK Ledger App to use Ledger Nano FW v.1.6.0. - Implement optimized Base58 from Ledger BTC App. - Improve overall project layout. - Add files to support development environment setup using Vagrant. - Update documentation. Significant changes can be found in the CHANGELOG, as well as the following pull requests: - added message signing features [#40](#40) - implement v2 Transactions [#27](#27) - added VendorField display support [#29](#29) - added build options and documentation [#32](#32) - merged updates from LedgerHQ/ledger-app-ark [#23](#23) - cleaned up warnings and refactored implementation [#25](#25) - upgraded `nanos-secure-sdk` version `1553` -> `160` [#46](#46) - refactor transactions classes to decouple Ledger SDK code [#51](#51) - unify Ledger NanoS and NanoX ux display flow [#53](#53) - implement support for large text fields [#55](#55) - use optimized Base58 implementation from Ledger BTC app [#66](#66) ## Supported in v.2.0.0 ### Transaction Versions: - v0 - v1 (_added_) - v2 (_added_) ### Signing Algorithms: - Ecdsa ### Operation Types: - Get PublicKey - Get App Configuration - Sign Message (_added_) - Sign Transaction ### Transaction Types: - v0 - Transfer - Vote - v1 (_added_) - Transfer - Vote - v2 (_added_) - Transfer - Second Signature Registration - Vote - IPFS - Htlc Lock - Htlc Claim - Htlc Refund ## Checklist - [x] Documentation _(if necessary)_ - [x] Ready to be merged
sleepdefic1t
added a commit
that referenced
this pull request
Feb 8, 2020
## Summary While there are no breaking changes from a users perspective, this release includes a massive rewrite of the project. Specific objectives accomplished within this release: - Support ARK Core v2 Transactions. - Support Message Signing. - Merge changes from `LedgerHQ/ledger-app-ark`. - Update the ARK Ledger App to use Ledger Nano FW v.1.6.0. - Implement optimized Base58 from Ledger BTC App. - Improve overall project layout. - Add files to support development environment setup using Vagrant. - Update documentation. Significant changes can be found in the CHANGELOG, as well as the following pull requests: - added message signing features [#40](#40) - implement v2 Transactions [#27](#27) - added VendorField display support [#29](#29) - added build options and documentation [#32](#32) - merged updates from LedgerHQ/ledger-app-ark [#23](#23) - cleaned up warnings and refactored implementation [#25](#25) - upgraded `nanos-secure-sdk` version `1553` -> `160` [#46](#46) - refactor transactions classes to decouple Ledger SDK code [#51](#51) - unify Ledger NanoS and NanoX ux display flow [#53](#53) - implement support for large text fields [#55](#55) - use optimized Base58 implementation from Ledger BTC app [#66](#66) ## Supported in v.2.0.0 ### Transaction Versions: - v0 - v1 (_added_) - v2 (_added_) ### Signing Algorithms: - Ecdsa ### Operation Types: - Get PublicKey - Get App Configuration - Sign Message (_added_) - Sign Transaction ### Transaction Types: - v0 - Transfer - Vote - v1 (_added_) - Transfer - Vote - v2 (_added_) - Transfer - Second Signature Registration - Vote - IPFS - Htlc Lock - Htlc Claim - Htlc Refund ## Checklist - [x] Documentation _(if necessary)_ - [x] Ready to be merged
sleepdefic1t
added a commit
that referenced
this pull request
Feb 8, 2020
## Summary While there are no breaking changes from a users perspective, this release includes a massive rewrite of the project. Specific objectives accomplished within this release: - Support ARK Core v2 Transactions. - Support Message Signing. - Merge changes from `LedgerHQ/ledger-app-ark`. - Update the ARK Ledger App to use Ledger Nano FW v.1.6.0. - Implement optimized Base58 from Ledger BTC App. - Improve overall project layout. - Add files to support development environment setup using Vagrant. - Update documentation. Significant changes can be found in the CHANGELOG, as well as the following pull requests: - added message signing features [#40](#40) - implement v2 Transactions [#27](#27) - added VendorField display support [#29](#29) - added build options and documentation [#32](#32) - merged updates from LedgerHQ/ledger-app-ark [#23](#23) - cleaned up warnings and refactored implementation [#25](#25) - upgraded `nanos-secure-sdk` version `1553` -> `160` [#46](#46) - refactor transactions classes to decouple Ledger SDK code [#51](#51) - unify Ledger NanoS and NanoX ux display flow [#53](#53) - implement support for large text fields [#55](#55) - use optimized Base58 implementation from Ledger BTC app [#66](#66) ## Supported in v.2.0.0 ### Transaction Versions: - v0 - v1 (_added_) - v2 (_added_) ### Signing Algorithms: - Ecdsa ### Operation Types: - Get PublicKey - Get App Configuration - Sign Message (_added_) - Sign Transaction ### Transaction Types: - v0 - Transfer - Vote - v1 (_added_) - Transfer - Vote - v2 (_added_) - Transfer - Second Signature Registration - Vote - IPFS - Htlc Lock - Htlc Claim - Htlc Refund ## Checklist - [x] Documentation _(if necessary)_ - [x] Ready to be merged ## Additional Discussion This patch release adds #66 to #65
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
per LedgerHQ CTO, the Base58 implementation in Ledger App BTC contains several performance optimizations and better bounds-checking.
This PR implements the optimized Base58 version.
Checklist