Skip to content
This repository has been archived by the owner on Feb 10, 2020. It is now read-only.

fix: maxlength of vendorfield #1

Merged
merged 5 commits into from
Dec 22, 2018

Conversation

kalgoop
Copy link
Contributor

@kalgoop kalgoop commented Dec 21, 2018

Proposed Change

take substring of value in vendorfield, if larger than 64 characters

if value is already less than 64 characters, substring function returns the same string

take substring of value in vendorfield, if larger than 64 characters
@alexbarnsley
Copy link

It would be better to throw an error I think. taking a substring could result in undesired effects for the person doing it

@faustbrian
Copy link
Contributor

As @alexbarnsley said an error is the way to do it as this could result in an order not being able to be paid.

@codecov-io
Copy link

codecov-io commented Dec 22, 2018

Codecov Report

Merging #1 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   85.82%   85.93%   +0.11%     
==========================================
  Files           1        1              
  Lines         127      128       +1     
  Branches       20       21       +1     
==========================================
+ Hits          109      110       +1     
  Misses         16       16              
  Partials        2        2
Impacted Files Coverage Δ
lib/index.js 85.93% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cdb18f...889d809. Read the comment docs.

lib/index.js Outdated Show resolved Hide resolved
@faustbrian faustbrian merged commit bd7e039 into ArkEcosystemArchive:master Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants