Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spoolman: add support for aditional headers #870

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LobodPl
Copy link

@LobodPl LobodPl commented Jun 17, 2024

Adds additional_headers parameter, to define extra headers passed with all spoolman requests.

Use case:
Spoolman has no auth and api is all public.
You use your printers in different locations, so you put Spoolman behind ZeroTrust (CloudFlare for example) to use only 1 instance.
You will need to pass extradata along with all spoolman requests to get through ZeroTrust Gateway.

Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
Signed-off-by: Damian Łoboda <konta.lobod@o2.pl>
@Arksine
Copy link
Owner

Arksine commented Jun 23, 2024

Thanks. I'm a bit weary of adding this functionality directly to Moonraker. It seems like it would be possible to proxy requests to Spoolman and add any additional necessary headers there, which would be the preferable way of handling unique setups that don't apply to the majority of users.

@LobodPl
Copy link
Author

LobodPl commented Jun 23, 2024

Thanks. I'm a bit weary of adding this functionality directly to Moonraker. It seems like it would be possible to proxy requests to Spoolman and add any additional necessary headers there, which would be the preferable way of handling unique setups that don't apply to the majority of users.

Hello, good point of view. For me my change is as rare as use of the spoolman itself, but right now I'm also sceptic if it should be a part of moonraker itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants