Added toggle include crew keybind #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepPork
added
feature
Kexanone
requested changes
Aug 28, 2018
| }; | ||
| }, | ||
| "", | ||
| [DIK_LMENU, [false, false, false]] |
There was a problem hiding this comment.
ALT as a default creates conflicts with existing keybindings that use ALT. I would set no keybinding, such that the players has to specify what suits for him.
CreepPork
added
the
testing/tested
|
I would prefer it to work when the set key is released then it should go back to its previous position just like in Eden. |
Kexanone
approved these changes
Sep 23, 2018
|
As I can’t review my own PR, it’s fine. |
CreepPork
added a commit
that referenced
this pull request
Dec 7, 2018
* Updated French Translations again (#355) * Updated translations again. * Another french translation update * Added Switch Unit to ACE Zeus Interaction menu #298 (#361) * Update Japanese translation (#363) * Replace linalg and statistics utilities with CBA and BIS functions (#368) * Use correct spawn position right from the beginning (#371) * Fix exception handling and add support LWIRCM from RHS (#369) * Fix exception handling and add support lwircm from RHS * Use localization * Handle VLS (#365) * Handle VLS * Remove loggers * Address CreepPork's glorious review * Use underscore for unused variable * Added toggle include crew keybind (#362) * Added toggle include crew keybind * Improve description and add FR/DE localization * fix grammar in FR translation * Make Eden-like toggle * Add Module Filter (#372) * Prevent modules from being added automatically * Prevent modules from being added automatically II * Faction filter: Add side to text and sort the entries * Add the available modules filter * Remove workaround from Achilles init * Reduce scheduled env to a minimum * Apply module filter to module tree loading EH * Fix undefined variable error in register custom modules * Fix custom modules and duplicates for loaded missions * Remove logger * Surprise (#370) * Add surprise * Update credits * Fix localization; Add destruction rate option * Not for curators * Remove changes to overcast * Update comments; Remove unused function * Prevent zero division error * Use CamelCase * Remove logger * Address review * Address 2nd review * Remove unnecessary comment * Extend Advanced CAS (#367) * Add interpolation and angle/rotation functions * update sqf_validator * Implement plane CAS * Offset radius correction * Implement standard deviation * Create a function for ownership changes * Add new icons * Add advanced CAS functions and update the module * Improve exception handling * Use BIS function * Fix spacing in cfgFunctions * Add examples * Use joinString * Use format instead of joinString * Add semicolon at the end * Use camelCase * Update to 1.2.0 (#373) * Update changlog and credits * Update version * Fix spelling * Remove unused localization * Fix spelling II * Fix Nuke (#374) * Handle the case where Zeus is the server * Fix the nuke module duplicate * Fixed typo #391 (#392) * Revise GUI grids (#385) * Increase maximum attribute window height * Use pp for BI GUI grids; Move grid defs to separate file; Use dynamic H grids for inventory attribute * Use grid defs from ui_f * Use .inc instead of .h for SQF inclusions * Include .inc in addon builder * Fix Rsc Display Attributes * Change .inc to .inc.sqf * Fix order in data array (#387) * Do not kill curators and logics (#384) * Do not kill curators and logics * Introduce _unitDies and handle Achilles revive in switchUnit functions * Nuke now kills switched units as well * Correct function name * Do not kill 'invincible' units * Revise Creation Tree Search Box (#407) * Revise fix for loss of sides in creation tab * Make use of CBA settings subcategories for faction/module filters * Fix for FIA: Include side id in filter * Port DZN search patch to Achilles * Address review * Extend comment * Fixed "Error: unit has no smokes" on buildings (#393) * Fixed wrong error message #382 * Address review * Revise toggle include crew keybind (#396) * Added feedback to player pressing toggle crew keybind #380 * Removed default keybind * Small fixes for 1.2.0 RC (#408) * Restore achilles modules when a player was promoted to Zeus * Fix the issue that countermeasure keybinding is triggered when using the creation search field * Add RHS AN/ALQ to CM * CAS: Player exception; No empty parentheses; Exclude CMs & LDs * Suppressive Fire: Exception handling for players * Transfer ownership: Filter groups with players * Fixed Armake complaints (#412) * Missing semicolon * Remove double semicolons; Add missing semicolons * Replace double double quotes * Replace more double double quotes * Remove invalid syntax * Update change log to 1.2.0 (#413) * Merge RC change logs * Fix spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: