Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module activation fix #417

Merged
merged 6 commits into from
Dec 7, 2018
Merged

Module activation fix #417

merged 6 commits into from
Dec 7, 2018

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Dec 7, 2018

When merged this pull request will:

@Kexanone Kexanone added fix PR that is a fixes a bug. priority/high Issue or PR that should be resolved as quickly as possible. labels Dec 7, 2018
@Kexanone Kexanone added this to the 1.2.1 milestone Dec 7, 2018
@Kexanone Kexanone self-assigned this Dec 7, 2018
@Kexanone Kexanone added the testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. label Dec 7, 2018
CreepPork
CreepPork previously approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing.

CreepPork
CreepPork previously approved these changes Dec 7, 2018
View reviewed changes
@Kexanone
Copy link
Member Author

Kexanone commented Dec 7, 2018

Prevented race condition by directly setting the activation.

@Kexanone Kexanone added testing/tested Indicates that the PR's latest commit has been tested and is working properly. and removed testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels Dec 7, 2018
@Kexanone Kexanone merged commit 1071c9f into master Dec 7, 2018
@Kexanone Kexanone deleted the moduleActivationFix branch December 7, 2018 22:15
@CreepPork CreepPork mentioned this pull request Dec 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

Assignees

@Kexanone Kexanone

Labels
fix PR that is a fixes a bug. priority/high Issue or PR that should be resolved as quickly as possible. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Kexanone @CreepPork