Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework pylon loadout attribute #454

Merged
merged 8 commits into from
May 6, 2019
Merged

Rework pylon loadout attribute #454

merged 8 commits into from
May 6, 2019

Conversation

neilzar
Copy link
Collaborator

@neilzar neilzar commented Feb 12, 2019

When merged this pull request will:

  • Improve performance of the Loadout attribute, 75% improvement
  • Always give the option for gunner/pilot when there is a gunner seat, not just when there is a unit in the seat.

@neilzar neilzar added change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels Feb 12, 2019
@neilzar neilzar self-assigned this Feb 12, 2019
@neilzar neilzar added this to the 1.3.0 milestone Feb 12, 2019
@neilzar
Copy link
Collaborator Author

neilzar commented Feb 12, 2019

Works fine when testing in Multiplayer alone, unsure whether removing the locality check for setPylonLoadout breaks it; I have never had to remote execute it but that could have been circumstantial.

CreepPork
CreepPork previously approved these changes Feb 17, 2019
View reviewed changes
@neilzar neilzar requested a review from Kexanone March 9, 2019 15:44
@CreepPork CreepPork added testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. testing/tested Indicates that the PR's latest commit has been tested and is working properly. and removed testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels Apr 27, 2019
@CreepPork
Copy link
Member

👍 Looks good to merge @neilzar.

@neilzar neilzar merged commit 676e895 into ArmaAchilles:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

@CreepPork CreepPork CreepPork approved these changes

Assignees

@neilzar neilzar

Labels
change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neilzar @CreepPork @Kexanone