Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prepare_documents #102

Merged
merged 5 commits into from
Mar 6, 2022
Merged

add prepare_documents #102

merged 5 commits into from
Mar 6, 2022

Conversation

ArneBinder
Copy link
Owner

Simple approach to handle #101. This also allows the user to easily integrate sophisticated logic to e.g. create candidate entity pairs for RE.

@ChristophAlt
Copy link
Collaborator

Why add another method? This only makes the workflow more complex to understand for users. How about adding a is_training: bool = False parameter to encode_inputand set it to encode_target in encode(...)?

@ChristophAlt
Copy link
Collaborator

ChristophAlt commented Mar 6, 2022

And while looking at the taskmodule I'd also recommend to remove the combine_output and create_annotations_from_output methods in a later commit, as it unnecessarily restricts the user and makes the workflow more complicated to understand and implement.

@ChristophAlt ChristophAlt merged commit ac53ce7 into main Mar 6, 2022
@ChristophAlt ChristophAlt deleted the enhancement/prepare_documents branch April 17, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants